> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java, > > line 405 > > <https://reviews.apache.org/r/47837/diff/1/?file=1393788#file1393788line405> > > > > This code seems to be for a different issue. Can you update with > > details on why this change is done both in jira and here? > > Rohini Palaniswamy wrote: > Can you clarify more? This code is not related to this jira. So please > add information to the jira on the actual issue that is being fixed here and > in the jira or move this to a separate jira. The comment in code mentions > what is being fixed, but you need to mention in the jira what is the affected > case scenario.
Added comment to JIRA. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review142151 ----------------------------------------------------------- On Aug. 1, 2016, 6:23 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47837/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 6:23 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2501 > https://issues.apache.org/jira/browse/OOZIE-2501 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2501 ZK reentrant lock doesn't work for few cases > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 41f4430f69cb7a9b132a4000c3e5c8aa7573c0a0 > core/src/main/java/org/apache/oozie/lock/MemoryLocks.java > 7d65ac0e24a62086732ec91fc24f89b62469451d > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b > core/src/main/java/org/apache/oozie/service/ZKLocksService.java > 952b90d5dfbfeccf4600238f75885c792709ffc7 > core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java > 61fec19b346748b22df1b58f014c32b1c04c8c1f > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > d1acadfff36fff637fb9ccb8e3feffb24248c792 > > Diff: https://reviews.apache.org/r/47837/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
