> On júl. 20, 2016, 1:21 du, Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java, > > line 158 > > <https://reviews.apache.org/r/50202/diff/1/?file=1447527#file1447527line158> > > > > Note: I know that this method has too many arguments. > > > > It doesn't look nice. A possible approach is to move some of the stuff > > (maps, app) to class variables. However I don't want to store state in this > > class - we only need these stuff during validation. Of course we could go > > ahead and re-create the maps & app variables during each validateWorkflow() > > call but I don't like that either. > > > > If someone has a good idea, don't hold it back. > > Robert Kanter wrote: > I know that too many arguments is considered bad style according to some, > but I have no problem with lots of arguments. The method needs them, so I > see nothing wrong with it.
Ok, cool :) - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50202/#review142927 ----------------------------------------------------------- On júl. 23, 2016, 5:54 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50202/ > ----------------------------------------------------------- > > (Updated júl. 23, 2016, 5:54 du) > > > Review request for oozie. > > > Bugs: OOZIE-1978 > https://issues.apache.org/jira/browse/OOZIE-1978 > > > Repository: oozie-git > > > Description > ------- > > See OOZIE-1978 for details. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/ErrorCode.java 2907ca2 > core/src/main/java/org/apache/oozie/service/ActionService.java becc69b > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a1b9cdb > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java > PRE-CREATION > core/src/test/java/org/apache/oozie/TestWorkflowBean.java b68f0f7 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 73464c8 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 9002b6c > core/src/test/resources/wf-long.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/50202/diff/ > > > Testing > ------- > > Existing tests pass. > > We might need to add some more, at least testing acyclic graph detection. > > > Thanks, > > Peter Bacsko > >
