----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50372/#review143499 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java (line 163) <https://reviews.apache.org/r/50372/#comment209312> Can you extract this part into a new method , something like private Configuration resolveVariablesFromConfigDefault(Configuration defaultConf)? Then you could just defaultConf = resolveVariablesFromConfigDefault(defaultConf); core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java (line 169) <https://reviews.apache.org/r/50372/#comment209311> Would it makes sense to log when this (rare) situation happens? It could be useful for later analysis. core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java (line 170) <https://reviews.apache.org/r/50372/#comment209310> Can you please extract entry.getKey() to a local String variable (e.g. defaultConfKey)? - Attila Sasvari On July 23, 2016, 4:58 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50372/ > ----------------------------------------------------------- > > (Updated July 23, 2016, 4:58 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2583 > https://issues.apache.org/jira/browse/OOZIE-2583 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2583: oozie throws EL Exception when reference variable name containing > dot > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 27274b9 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 73464c8 > > Diff: https://reviews.apache.org/r/50372/diff/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Abhishek Bafna > >
