----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50372/#review143696 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java (line 299) <https://reviews.apache.org/r/50372/#comment209602> It is good that we now log the conf key, but I am wondering if the associated value contains sensitive information (such as some passwords). If so, we should mask it when logging or it might be better to not log the actual value at all. - Attila Sasvari On July 26, 2016, 11:02 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50372/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 11:02 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2583 > https://issues.apache.org/jira/browse/OOZIE-2583 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2583: oozie throws EL Exception when reference variable name containing > dot > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 27274b9 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 73464c8 > > Diff: https://reviews.apache.org/r/50372/diff/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Abhishek Bafna > >
