[
https://issues.apache.org/jira/browse/OOZIE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-1986:
--------------------------------
Attachment: summary.txt
OOZIE-1986.005.patch
Some lines were broken so that these can fit into 132 chars. For some others
it's not feasible being {{String}} constants.
We also delete the JAR file and the MD5 file after having checked.
Moreover, in the summary file we also enlist the most severe errors
({{summary.txt}}).
Current {{stdout}} is:
{code}
[TRACE] Downloading FindBugs diff JAR from
https://github.com/adjohnson916/findbugs-diff/releases/download/v0.1.0/findbugs-diff-0.1.0-all.jar
[TRACE] FindBugs diff JAR downloaded
[TRACE] FindBugs diff JAR checked, is safe to use
[TRACE] Performing FindBugs diffs
[TRACE] FindBugs diff JAR removed
[TRACE] FindBugs diffs performed
[TRACE] Checking FindBugs diffs and creating reports
[DEBUG] There are no new bugs found in [client].
[ERROR] There are [2] new bugs found below threshold in [core].
[DEBUG] You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
[DEBUG] There are no new bugs found in [docs].
[DEBUG] There are no new bugs found in [examples].
[DEBUG] There are no new bugs found in [hadooplibs/hadoop-utils-2].
[DEBUG] There are no new bugs found in [sharelib/distcp].
[DEBUG] There are no new bugs found in [sharelib/hcatalog].
[DEBUG] There are no new bugs found in [sharelib/hive].
[DEBUG] There are no new bugs found in [sharelib/hive2].
[DEBUG] There are no new bugs found in [sharelib/oozie].
[DEBUG] There are no new bugs found in [sharelib/pig].
[DEBUG] There are no new bugs found in [sharelib/spark].
[DEBUG] There are no new bugs found in [sharelib/sqoop].
[DEBUG] There are no new bugs found in [sharelib/streaming].
[DEBUG] There are no new bugs found in [tools].
[ERROR] There are [2] new bugs found below threshold in total that must be
fixed.
[TRACE] FindBugs diffs checked and reports created
Process finished with exit code 0
{code}
> Add FindBugs report to pre-commit build
> ---------------------------------------
>
> Key: OOZIE-1986
> URL: https://issues.apache.org/jira/browse/OOZIE-1986
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-1986.001.patch, OOZIE-1986.002.patch,
> OOZIE-1986.003.patch, OOZIE-1986.004.patch, OOZIE-1986.005.patch, summary.txt
>
>
> Now that we have OOZIE-1793, it will be really useful to have the pre-commit
> build generate a findbugs report. It should probably before and after the
> patch and only complain it there are more after. And it should link to the
> report. Ideally, this would do some kind of diff (like Hadoop does) so it's
> easy to identify the new findbugs items.
> You can generate the findbugs reports by running:
> {noformat}
> mvn verify -DskipTests
> {noformat}
> This also runs checkstyle
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
