> On Oct. 7, 2016, 2:22 p.m., Attila Sasvari wrote: > > bin/test-patch-11-findbugs-diff, line 121 > > <https://reviews.apache.org/r/52429/diff/3/?file=1526278#file1526278line121> > > > > Should not we clean up / delete this directory at the end of the > > execution? > > > > > > If not and we decide to keep the jar / directory for some reason, then > > it is not necessary to download findbugs diff jar each time. For example it > > can happen that jenkins jobs run on the same build server. In this case we > > could just reuse the already downloaded jar (if its md5 checksum is OK). > > What do you think?
After performing FindBugs diff analysis both the JAR and the MD5 files are removed. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52429/#review151797 ----------------------------------------------------------- On Oct. 7, 2016, 10:39 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52429/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 10:39 a.m.) > > > Review request for oozie and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > We go for that solution: > > 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes > right after compile > > 2. `mvn clean verify -DskipTests` before and after applying the patch, and > saving each and every module's `target/findbugs/findbugsXml.xml` to a secure > folder > > 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs > > 4. analyze all the `findbugs-new.xml` entries for nodes with XPath > `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` > and / or `rank` lower than threshold > > 5. have the reports merged and be downloadable in any case in following > scenarios: > > * -1 for bugs that are too serious to apply the patch with them > * 0 for other new bugs > * +1 if there is no new bug > > > Diffs > ----- > > bin/test-patch-11-findbugs-diff PRE-CREATION > bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION > pom.xml a33d2c5 > > Diff: https://reviews.apache.org/r/52429/diff/ > > > Testing > ------- > > > Thanks, > > András Piros > >
