> On Oct. 12, 2016, 2 p.m., Attila Sasvari wrote:
> > bin/test-patch-11-findbugs-diff, line 179
> > <https://reviews.apache.org/r/52429/diff/2-4/?file=1518708#file1518708line179>
> >
> >     You can move theses two lines to cleanup_and_exit() if possible 
> >     rm -f "${DIFF_DIR}/${FINDBUGS_JAR}" "${DIFF_DIR}/${FINDBUGS_JAR}.md5"
> >     echo "[TRACE] FindBugs diff JAR removed"
> >     (add an if that tests if jar and md5 are there)
> >     
> >     call cleanup_and_exit at the end in the report switch case

Done.


- András


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review152302
-----------------------------------------------------------


On Oct. 12, 2016, 2:45 p.m., András Piros wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 2:45 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> We go for that solution:
> 
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes 
> right after compile
> 
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and 
> saving each and every module's `target/findbugs/findbugsXml.xml` to a secure 
> folder
> 
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
> 
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath 
> `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` 
> and / or `rank` lower than threshold
> 
> 5. have the reports merged and be downloadable in any case in following 
> scenarios:
> 
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
> 
> 
> Diffs
> -----
> 
>   bin/test-patch-11-findbugs-diff PRE-CREATION 
>   bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION 
>   pom.xml 83a1d42 
> 
> Diff: https://reviews.apache.org/r/52429/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> András Piros
> 
>

Reply via email to