[ 
https://issues.apache.org/jira/browse/OOZIE-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672346#comment-15672346
 ] 

Satish Subhashrao Saley edited comment on OOZIE-2737 at 11/17/16 1:30 AM:
--------------------------------------------------------------------------

Hi Andras,
Thank you for review. I created a method for {{waitFor()}}. But implementation 
of {{Predicate}} would be different for different tests , not a good idea to 
have class. 

Hi [~gezapeti],
I saw you fixing flaky tests having {{sleep}}. Would you also take  a look this 
patch? 


was (Author: satishsaley):
Hi Andras,
Thank you for review. I created a method for {{waitFor()}}. But implementation 
of {{Predicate}} would be different for different tests , not a good idea to 
have class. 

Hi @gezapeti,
I saw you fixing flaky tests having {{sleep}}. Would you also take  a look this 
patch? 

> testConfigDefaultPropsToAction is flaky
> ---------------------------------------
>
>                 Key: OOZIE-2737
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2737
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Satish Subhashrao Saley
>            Assignee: Satish Subhashrao Saley
>            Priority: Minor
>         Attachments: OOZIE-2737-1.patch, OOZIE-2737-2.patch
>
>
> - Error Message
> {code}
> expected:<[hdfs://localhost:60030]> but was:<[${nameNode}]>
> {code}
> - Stacktrace
> {code}
> -------------------------------------------------------------------------------
> Test set: org.apache.oozie.action.hadoop.TestMapReduceActionExecutor
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 32.661 sec 
> <<< FAILURE!
> testConfigDefaultPropsToAction(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor)
>   Time elapsed: 0.03 sec  <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[hdfs://localhost:65506]> but 
> was:<[${nameNode}]>
>       at junit.framework.Assert.assertEquals(Assert.java:85)
>       at junit.framework.Assert.assertEquals(Assert.java:91)
>       at 
> org.apache.oozie.action.hadoop.TestMapReduceActionExecutor.testConfigDefaultPropsToAction(TestMapReduceActionExecutor.java:150)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at junit.framework.TestCase.runTest(TestCase.java:168)
>       at junit.framework.TestCase.runBare(TestCase.java:134)
>       at junit.framework.TestResult$1.protect(TestResult.java:110)
>       at junit.framework.TestResult.runProtected(TestResult.java:128)
>       at junit.framework.TestResult.run(TestResult.java:113)
>       at junit.framework.TestCase.run(TestCase.java:124)
>       at junit.framework.TestSuite.runTest(TestSuite.java:243)
>       at junit.framework.TestSuite.run(TestSuite.java:238)
>       at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>       at org.junit.runners.Suite.runChild(Suite.java:128)
>       at org.junit.runners.Suite.runChild(Suite.java:24)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>       at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>       at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to