> On Dec. 5, 2016, 6:15 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java, line 84
> > <https://reviews.apache.org/r/54383/diff/1/?file=1576464#file1576464line84>
> >
> > Collections.emptySet().iterator()
I guess it is the same thing.
public static final <T> Set<T> emptySet() {
return (Set<T>) EMPTY_SET;
}
> On Dec. 5, 2016, 6:15 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java, line 323
> > <https://reviews.apache.org/r/54383/diff/1/?file=1576464#file1576464line323>
> >
> > Extract method
I believe you mean extract throw statement into a separate method and use the
method.
I think, it will involde more work (computation) into calling a method and then
throwing the exception, instead of throwing directly. Thanks.
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54383/#review158020
-----------------------------------------------------------
On Dec. 5, 2016, 5:05 p.m., Abhishek Bafna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54383/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 5:05 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2751
> https://issues.apache.org/jira/browse/OOZIE-2751
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> LocalOozieClient is missing methods from OozieClient
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/client/OozieClient.java 12c80cb
> core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java PRE-CREATION
> core/src/main/java/org/apache/oozie/LocalOozieClient.java f734f76
> core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java
> PRE-CREATION
> core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 32b0cd0
>
> Diff: https://reviews.apache.org/r/54383/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abhishek Bafna
>
>
