> On Dec. 5, 2016, 6:15 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java, lines 351-376 > > <https://reviews.apache.org/r/54383/diff/1/?file=1576464#file1576464line351> > > > > Would be better to extract to an Abstract Factory.
Moved them to a separate abstract class and used the same into Servlet classes as well. :) > On Dec. 5, 2016, 6:15 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java, lines 234-258 > > <https://reviews.apache.org/r/54383/diff/1/?file=1576464#file1576464line234> > > > > I would extract this to another - generic - method. The difference is > > only within casting to that generic type, and applying the logic method - > > that can be a `Function<F, T>` applying `engine.killJobs()` and > > `getXXXXJsonObject()`: > > > > > > https://google.github.io/guava/releases/19.0/api/docs/com/google/common/base/Function.html All these (killJobs, suspendJobs and resumeJobs) are not present in the BaseEngine class, that is why type-casting. I might need some more elobration on this, otherwise. Thanks. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54383/#review158020 ----------------------------------------------------------- On Dec. 5, 2016, 5:05 p.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54383/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 5:05 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2751 > https://issues.apache.org/jira/browse/OOZIE-2751 > > > Repository: oozie-git > > > Description > ------- > > LocalOozieClient is missing methods from OozieClient > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 12c80cb > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java PRE-CREATION > core/src/main/java/org/apache/oozie/LocalOozieClient.java f734f76 > core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java > PRE-CREATION > core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 32b0cd0 > > Diff: https://reviews.apache.org/r/54383/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
