[
https://issues.apache.org/jira/browse/OOZIE-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804353#comment-15804353
]
Peter Cseh commented on OOZIE-1770:
-----------------------------------
Thanks you for the review @rkanter! We'll check out the review board comments
with [~pbacsko].
Regarding your other comments:
# most of the TODOs and FIXMEs already have jiras, but we will go over them
again and make sure that the jiras are referenced from the comments and they
are set to blocker.
# I would argue for not splitting up this patch. I agree, the patch is doing
several things, but It think dropping Hadoop1 as part of this is not a big
problem. I've tried to cherry-pick [~asasvari]'s commit for OOZIE-2316 that
removed hadoop1, but after OOZIE-2675 it has a lot of conflicts and resolving
them would double the work of doing it. Most of the code cleanups are
unfortunately not separated out to commits, they are part of commits with
actual development. Because of this, it would be hard to pick them out from
this patch. We'll create separate improvement jiras in the future for such
cases.
Running an organize imports (and/or an autoformatter) on all classes is a good
idea. I would argue for having a common IDE ruleset for contributors would make
sense.
> Create Oozie Application Master for YARN
> ----------------------------------------
>
> Key: OOZIE-1770
> URL: https://issues.apache.org/jira/browse/OOZIE-1770
> Project: Oozie
> Issue Type: New Feature
> Reporter: Bowen Zhang
> Assignee: Peter Cseh
> Attachments: OOZIE-1770-001.patch, OOZIE-1770-002.patch,
> OOZIE-1770-003.patch, OOZIE-1770-004.patch, OOZIE-1770-005.patch,
> OOZIE-1770-006.patch, OYA Scoping Doc 001.pdf, OozieYarnAM.pdf, Prelim OYA
> Scoping Doc 001.pdf, Prelim OYA Scoping Doc 002.pdf, Prelim OYA Scoping Doc
> 003.pdf, oya-rm-screenshot.jpg, oya.patch
>
>
> After the first release of oozie on hadoop 2, it will be good if users can
> set execution engine in oozie conf, be it YARN AM or traditional MR. We can
> target this for post oozie 4.1 release.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
