[
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807553#comment-15807553
]
Peter Cseh commented on OOZIE-2769:
-----------------------------------
Thanks for the contribution [~dbist13]!
We have some flaky tests around unfortunately,
{{testMemoryUsageAndSpeedOverflowToDisk}} is one of them. It can be ignored.
Some thoughts on your patch:
# Please check the patch for trailing whitespaces and remove them
# I would add the test back. It was failing because it's checking for the
replication factor of the {{path}} instead of the {{outputFile}}:
{code}
ae.setrep(context, *outputFile*, (short) 3);
assertEquals(fs.getFileStatus(*path*).getReplication(), 3);
{code}
Please switch the arguments for {{assertEquals}}, the expected value should be
the first one.
# I don't think there's a need for {{setrep(Context context, XConfiguration
fsConf, Path nameNodePath, Path path, short replicationFactor)}}. I would
simply inline it and use {{null}} where it's needed.
# Please add documentation for this feature in {{WorkflowFunctionalSpec.twiki}}
> Extend FS action to allow setrep on a file
> ------------------------------------------
>
> Key: OOZIE-2769
> URL: https://issues.apache.org/jira/browse/OOZIE-2769
> Project: Oozie
> Issue Type: Improvement
> Components: action, core
> Affects Versions: 4.2.0
> Reporter: Artem Ervits
> Priority: Minor
> Labels: easyfix, features, patch
> Fix For: trunk
>
> Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature
> extends FS action to allow for setrep on an HDFS file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
