[ 
https://issues.apache.org/jira/browse/OOZIE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811159#comment-15811159
 ] 

Peter Cseh commented on OOZIE-2769:
-----------------------------------

Thanks for the update!
Th long line was probably for the method {{setrep(Context context, 
XConfiguration fsConf, Path nameNodePath, Path path, short 
replicationFactor)}}. I think it still has two unnecessary parameters, which 
are always null and should be removed.
I don't know what's wrong with the test, but the test in patch-0 works if I 
change the {{path}} to {{outputFile}} in the asserts.

I haven't tried it out, but based on the code the documentation and the example 
should say
{noformat}
 <setrep path='[PATH]' replication-factor=n/>
{noformat}
or something like that.
Also, I've just noticed that the {{oozie-workflow-0.5.xsd}} have to be updated 
to accept the new command. 
Can you add a test with a workflow.xml file that uses this parameter?

> Extend FS action to allow setrep on a file
> ------------------------------------------
>
>                 Key: OOZIE-2769
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2769
>             Project: Oozie
>          Issue Type: Improvement
>          Components: action, core
>    Affects Versions: 4.2.0
>            Reporter: Artem Ervits
>            Priority: Minor
>              Labels: easyfix, features, patch
>             Fix For: trunk
>
>         Attachments: OOZIE-2769-0.patch, OOZIE-2769-1.patch, 
> OOZIE-2769-2.patch, OOZIE-2769-3.patch
>
>
> Today, Oozie FS action can only do delete/move/chgrp/chmod, this feature 
> extends FS action to allow for setrep on an HDFS file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to