[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823294#comment-15823294
]
Attila Sasvari commented on OOZIE-2041:
---------------------------------------
[~abhishekbafna] Thanks for the updated patch! Could you please re-upload the
patch to re-trigger jenkins QA job?
Some "Nit" comments:
* In {{schedulePurgeCommand}} you do not the {{else}} clause if you throw an
exception in the {{if}} part.
* Typo in the documentation: "bundle records (bundle=6) older than 7 days."
* In {{OozieClient}}, you could add some parameter validation like this
{code}
Integer wf = Ints.tryParse(workflowAge);
checkArgument( wf != null && wf.intValue() > 0, "wf must be a positive
number, found: '%s'.", workflowAge);
{code}
> Add an admin command to run the PurgeXCommand
> ---------------------------------------------
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
