[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834672#comment-15834672
]
Attila Sasvari commented on OOZIE-2041:
---------------------------------------
[~abhishekbafna] thanks for reuploading the patch
Regarding the typo
{quote}
Purge command will delete the workflow records (wf=30) older than 30 days,
coordinator records (coord=7) older than 7 days and
bundle records (bundle=6) older then 7 days. The limit (limit=10) defines,
number of records to be fetch at a time. Turn
(oldCoordAction=true/false) =on/off= coordinator action record purging for long
running coordinators. If any of the parameter is
{quote}
Look at the description
* "workflow records (wf=30) older than 30 days" ,
* "(coord=7) older than 7 days",
* "(bundle=6) older then 7 days"
The last two are not consistent. That's why I think you wanted to write
"(bundle=*7*) older then 7 days"
Regarding validation
* in my opinion, doing the validation at the client side (using CLI) would
provide faster feedback to the user and put less pressure on the server (i.e.
it is not needed to send over the request to the server in case of an invalid
input). Sure, the request is validated on server side, but I only see
advantages to do this validation redundantly. Anyway, it is just a suggestion,
we can create a follow up jira or something.
Regarding CLI - I did not face issues.
> Add an admin command to run the PurgeXCommand
> ---------------------------------------------
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
