----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54726/#review161879 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 389) <https://reviews.apache.org/r/54726/#comment233162> Get information of the retry attempts for a given worklow action client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 1509) <https://reviews.apache.org/r/54726/#comment233172> Attempt instead of Retry client/src/main/java/org/apache/oozie/client/rest/RestConstants.java (line 84) <https://reviews.apache.org/r/54726/#comment233175> Typo in RETIRS. Also can be just retries instead of action-retries similar to the commandline argument. core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java (lines 70 - 73) <https://reviews.apache.org/r/54726/#comment233176> retry.1.startTime or rather attempt.1.startTime would read grammatically better than startTime.retry.1 and also will make all the retry params to have same prefix. Can actually get rid of the constants here and just prepend directly to JsonTags.WORKFLOW_ACTION_START_TIME in JobUtils. Same for other tags. core/src/main/java/org/apache/oozie/command/wf/WorkflowActionRetryInfoXCommand.java (line 53) <https://reviews.apache.org/r/54726/#comment233180> Can just return List<Map<String, String>> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java (lines 308 - 309) <https://reviews.apache.org/r/54726/#comment233179> You should return a list instead of map so that the attempts are always returned in order docs/src/site/twiki/DG_CommandLineTool.twiki (line 108) <https://reviews.apache.org/r/54726/#comment233181> Get information of the retry attempts for a given worklow action (requires -info and -action) docs/src/site/twiki/DG_CommandLineTool.twiki (line 629) <https://reviews.apache.org/r/54726/#comment233182> Listing all retry attempts of a worklow action docs/src/site/twiki/DG_CommandLineTool.twiki (line 631) <https://reviews.apache.org/r/54726/#comment233183> To get information on all the retry attempts of a workflow action specifying flag *=retries=* along with *=action=* flag with the action id in the =info= command. docs/src/site/twiki/WebServicesAPI.twiki (line 1356) <https://reviews.apache.org/r/54726/#comment233184> Retrive information on the retry attempts of the worklow action docs/src/site/twiki/WebServicesAPI.twiki (line 1359) <https://reviews.apache.org/r/54726/#comment233185> 0000000-161212175234862-oozie-puru-W?type=action&scope=pig-node&show=retries to be consistent with all other retries webapp/src/main/webapp/oozie-console.js (lines 801 - 802) <https://reviews.apache.org/r/54726/#comment233186> populateRetries before the function does not look right. Indentation also seems to be off - Rohini Palaniswamy On Dec. 14, 2016, 7:01 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54726/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2016, 7:01 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2691 > https://issues.apache.org/jira/browse/OOZIE-2691 > > > Repository: oozie-git > > > Description > ------- > > Show workflow action retry count to UI > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > e67fae9e2c7b32c1f209c24b4aba98daba96c06e > client/src/main/java/org/apache/oozie/client/OozieClient.java > 12c80cbf422447c8d5c98e6ba95737e127087173 > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 397e9ede8ebf63281c7f56f9cb9ee44c1518a1ed > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 41293642b06743294e4a640a2c66865b4e64eebd > core/src/main/java/org/apache/oozie/DagEngine.java > 7597142551e78e50e727b3076a5ec93a65b04c36 > core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > d0551ff094477d511aa95527adf1071dc2775c6f > core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 740b8d3f101352e951001af689e541ffbf606b52 > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > edfac48443efcc35c4aa2efbdca142f7d4d051d6 > core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 836e5d4f3f7d10233a1c1e8a007a44c6f4cfc78e > > core/src/main/java/org/apache/oozie/command/wf/WorkflowActionRetryInfoXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 21105223b1a8a819b4ec091e1a513e5751b51425 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 86ff278e6ff3b6ad9f2e7ea1d3e87446e404d122 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 60f1029d49f78bff973bd167791cfcdaaa1af60f > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java > 662a7ff26ff802bcdb530af71b52685bad089a6c > core/src/main/java/org/apache/oozie/util/JobUtils.java > a7a53b355d194b55959ede20c85d38e02294853d > core/src/test/java/org/apache/oozie/ForTestingActionExecutor.java > a70dc0200984798e06101bb0976df94f94a41cbe > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > ce95ff34030c97b56ed9257ebe027833493a9fa1 > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 60b7735c5d3fc06c27d4be164c48d90786ae4265 > core/src/test/resources/wf-ext-schema.xsd > 48aecf570cbd727ee9127aff2d24f02017dfb61d > docs/src/site/twiki/DG_CommandLineTool.twiki > 35eee40363ffb8d998df34a693ee318cf70a230f > docs/src/site/twiki/WebServicesAPI.twiki > b76e9343087a8c68825d222720543dc6d4d9f27a > webapp/src/main/webapp/oozie-console.js > 11c6940bb26c1a8318781ce62926b6e4a185e37c > > Diff: https://reviews.apache.org/r/54726/diff/ > > > Testing > ------- > > $ oozie job -info 0000000-161212175234862-oozie-puru-W@:start: -oozie > http://localhost:11000/oozie -retries > ID : 0000000-161212175234862-oozie-puru-W@:start: > No Retries > ------------------------------------------------------------------------------------------------------------------------------------ > $ job -info 0000000-161212175234862-oozie-puru-W@pig-node -oozie > http://localhost:11000/oozie -retries > ID : 0000000-161212175234862-oozie-puru-W@pig-node > ------------------------------------------------------------------------------------------------------------------------------------ > Retry : 1 > Start Time : Tue, 13 Dec 2016 01:54:13 GMT > End Time : Tue, 13 Dec 2016 01:54:20 GMT > Console URL : > http://localhost:50030/jobdetails.jsp?jobid=job_201612051339_2648 > ------------------------------------------------------------------------------------------------------------------------------------ > Retry : 2 > Start Time : Tue, 13 Dec 2016 01:55:20 GMT > End Time : Tue, 13 Dec 2016 01:55:24 GMT > Console URL : > http://localhost:50030/jobdetails.jsp?jobid=job_201612051339_2649 > ------------------------------------------------------------------------------------------------------------------------------------ > Retry : 3 > Start Time : Tue, 13 Dec 2016 01:56:24 GMT > End Time : Tue, 13 Dec 2016 01:56:27 GMT > Console URL : > http://localhost:50030/jobdetails.jsp?jobid=job_201612051339_2650 > ------------------------------------------------------------------------------------------------------------------------------------ > $ > > > Thanks, > > Purshotam Shah > >
