> On Jan. 20, 2017, 6:17 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java, lines
> > 70-73
> > <https://reviews.apache.org/r/54726/diff/1/?file=1584696#file1584696line70>
> >
> > This used for storage. Since informations are stored in jobs table, we
> > need to append constant.
> >
> > Inside oozie ( code/storage) we always use retry word ( like retry
> > interval, retry duration, retry count..). So it's more appropriate to use
> > retry rather than attempt.
>
> Rohini Palaniswamy wrote:
> retry is fine. But use prefix instead of suffix which is the standard we
> generally use for naming configuration. i.e retry.1.startTime instead of
> startTime.retry.1
>
> Purshotam Shah wrote:
> I thought the best practice is to put version number as suffix. Here
> retry is a version number. And regarding keyword retry, looking at some of
> Hadoop configuration, retry/attempt always comes at end
> (dfs.client.block.write.retries, dfs.client.cached.conn.retry ).
Those are just setting names and there is no version number in them. The prefix
in that case is dfs.client which groups all dfs.client settings together. You
need to have a common prefix. So that if required in future all retry settings
can be searched with configname.startsWith("retry"). startTime.retry.1 does
not even read right.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54726/#review162451
-----------------------------------------------------------
On Jan. 20, 2017, 6:24 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54726/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:24 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2691
> https://issues.apache.org/jira/browse/OOZIE-2691
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Show workflow action retry count to UI
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java
> e67fae9e2c7b32c1f209c24b4aba98daba96c06e
> client/src/main/java/org/apache/oozie/client/OozieClient.java
> 12c80cbf422447c8d5c98e6ba95737e127087173
> client/src/main/java/org/apache/oozie/client/rest/JsonTags.java
> 397e9ede8ebf63281c7f56f9cb9ee44c1518a1ed
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java
> 41293642b06743294e4a640a2c66865b4e64eebd
> core/src/main/java/org/apache/oozie/DagEngine.java
> 7597142551e78e50e727b3076a5ec93a65b04c36
> core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
> d0551ff094477d511aa95527adf1071dc2775c6f
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java
> 740b8d3f101352e951001af689e541ffbf606b52
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
> edfac48443efcc35c4aa2efbdca142f7d4d051d6
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
> 836e5d4f3f7d10233a1c1e8a007a44c6f4cfc78e
>
> core/src/main/java/org/apache/oozie/command/wf/WorkflowActionRetryInfoXCommand.java
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java
> 21105223b1a8a819b4ec091e1a513e5751b51425
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
> 86ff278e6ff3b6ad9f2e7ea1d3e87446e404d122
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
> 60f1029d49f78bff973bd167791cfcdaaa1af60f
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java
> 662a7ff26ff802bcdb530af71b52685bad089a6c
> core/src/main/java/org/apache/oozie/util/JobUtils.java
> a7a53b355d194b55959ede20c85d38e02294853d
> core/src/test/java/org/apache/oozie/ForTestingActionExecutor.java
> a70dc0200984798e06101bb0976df94f94a41cbe
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java
> ce95ff34030c97b56ed9257ebe027833493a9fa1
>
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java
> 60b7735c5d3fc06c27d4be164c48d90786ae4265
> core/src/test/resources/wf-ext-schema.xsd
> 48aecf570cbd727ee9127aff2d24f02017dfb61d
> docs/src/site/twiki/DG_CommandLineTool.twiki
> 35eee40363ffb8d998df34a693ee318cf70a230f
> docs/src/site/twiki/WebServicesAPI.twiki
> b76e9343087a8c68825d222720543dc6d4d9f27a
> webapp/src/main/webapp/oozie-console.js
> 11c6940bb26c1a8318781ce62926b6e4a185e37c
>
> Diff: https://reviews.apache.org/r/54726/diff/
>
>
> Testing
> -------
>
> $ oozie job -info 0000000-161212175234862-oozie-puru-W@:start: -oozie
> http://localhost:11000/oozie -retries
> ID : 0000000-161212175234862-oozie-puru-W@:start:
> No Retries
> ------------------------------------------------------------------------------------------------------------------------------------
> $ job -info 0000000-161212175234862-oozie-puru-W@pig-node -oozie
> http://localhost:11000/oozie -retries
> ID : 0000000-161212175234862-oozie-puru-W@pig-node
> ------------------------------------------------------------------------------------------------------------------------------------
> Retry : 1
> Start Time : Tue, 13 Dec 2016 01:54:13 GMT
> End Time : Tue, 13 Dec 2016 01:54:20 GMT
> Console URL :
> http://localhost:50030/jobdetails.jsp?jobid=job_201612051339_2648
> ------------------------------------------------------------------------------------------------------------------------------------
> Retry : 2
> Start Time : Tue, 13 Dec 2016 01:55:20 GMT
> End Time : Tue, 13 Dec 2016 01:55:24 GMT
> Console URL :
> http://localhost:50030/jobdetails.jsp?jobid=job_201612051339_2649
> ------------------------------------------------------------------------------------------------------------------------------------
> Retry : 3
> Start Time : Tue, 13 Dec 2016 01:56:24 GMT
> End Time : Tue, 13 Dec 2016 01:56:27 GMT
> Console URL :
> http://localhost:50030/jobdetails.jsp?jobid=job_201612051339_2650
> ------------------------------------------------------------------------------------------------------------------------------------
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>
