[ 
https://issues.apache.org/jira/browse/OOZIE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871030#comment-15871030
 ] 

Robert Kanter commented on OOZIE-2796:
--------------------------------------

A few comments:
# Let's add a constant somewhere for {{oozie.action.keep.action.dir}}.  It's 
used in a few files.
# In the catch statement in the {{testExceptionHandling}} test, it's good to 
assert something unique about the expected exception to make sure it's not 
hitting that for some other reason.  e.g. the error code or part of the error 
message.
# {{JavaActionExecutor#cleanUpActionDir}} and the code changes you made seem 
redundant (though it obviously wasn't working before so apparently not).  Do we 
actually need both?

> oozie.action.keep.action.dir not getting noticed
> ------------------------------------------------
>
>                 Key: OOZIE-2796
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2796
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>            Reporter: Andras Piros
>            Assignee: Xiaobin Zheng
>             Fix For: trunk
>
>         Attachments: OOZIE-2796-1.patch, OOZIE-2796-2.patch, 
> OOZIE-2796-3.patch
>
>
> When trying to add following configuration entry:
> {code:xml}
> <property>
>     <name>oozie.action.keep.action.dir</name>
>     <value>true</value>
> </property>
> {code}
> to the application level configuration of {{workflow.xml}}, the workflow 
> directories are removed just after the workflow has finished.
> This should not be the case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to