[
https://issues.apache.org/jira/browse/OOZIE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893541#comment-15893541
]
Robert Kanter commented on OOZIE-2796:
--------------------------------------
I didn't notice this before, but this now adds an extra DB call every time a
workflow ends ({{getWfConfiguration}} executed {{GET_WORKFLOW_ACTION_OP}}) to
get the configuration. Plus, it does this during {{execute}} when it should do
this during {{loadState}}.
In any case, I think it would be better if we loaded the configuration when we
load the {{WorkflowJob}} object because we're already making a DB call.
{{KillXCommand}}, {{SignalXCommand}}, and {{ActionStartXCommand}} are the only
places where {{WfEndXCommand}} is called so it shouldn't be too hard to change
that. In fact, {{SignalXCommand}} loads the {{WorkflowJob}} using
{{GET_WORKFLOW}}, which IIRC gets every field so the configuration should
already be there.
> oozie.action.keep.action.dir not getting noticed
> ------------------------------------------------
>
> Key: OOZIE-2796
> URL: https://issues.apache.org/jira/browse/OOZIE-2796
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 4.3.0
> Reporter: Andras Piros
> Assignee: Xiaobin Zheng
> Fix For: trunk
>
> Attachments: OOZIE-2796-1.patch, OOZIE-2796-2.patch,
> OOZIE-2796-3.patch, OOZIE-2796-4.patch
>
>
> When trying to add following configuration entry:
> {code:xml}
> <property>
> <name>oozie.action.keep.action.dir</name>
> <value>true</value>
> </property>
> {code}
> to the application level configuration of {{workflow.xml}}, the workflow
> directories are removed just after the workflow has finished.
> This should not be the case.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
