[ 
https://issues.apache.org/jira/browse/OOZIE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobin Zheng updated OOZIE-2796:
---------------------------------
    Attachment: OOZIE-2796-4.patch

Thanks for the comments [~rkanter]! 

I am attaching patch 4:
1. created a constant in WorkflowXCommand.java
2. made the exception handling unit test case more specific by asserting the 
error code.
Regarding 3, each action tries to clean up the action dir, and upon workflow 
end we clean up workflow dir. There seems very subtle difference between these 
two operations. I am not sure if workflow dir only contains action dir though. 
But arguably, it might be fine/better to clean up each action's dir if needed 
as soon as the action is done. So I slightly prefer to leave it as is to be 
more cautious.

Please take a look and let me know if you have other concerns.

> oozie.action.keep.action.dir not getting noticed
> ------------------------------------------------
>
>                 Key: OOZIE-2796
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2796
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>            Reporter: Andras Piros
>            Assignee: Xiaobin Zheng
>             Fix For: trunk
>
>         Attachments: OOZIE-2796-1.patch, OOZIE-2796-2.patch, 
> OOZIE-2796-3.patch, OOZIE-2796-4.patch
>
>
> When trying to add following configuration entry:
> {code:xml}
> <property>
>     <name>oozie.action.keep.action.dir</name>
>     <value>true</value>
> </property>
> {code}
> to the application level configuration of {{workflow.xml}}, the workflow 
> directories are removed just after the workflow has finished.
> This should not be the case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to