[
https://issues.apache.org/jira/browse/OOZIE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaobin Zheng updated OOZIE-2796:
---------------------------------
Attachment: OOZIE-2796-5.patch
Thanks for the pointer [~rkanter]!
I have made changes accordingly in latest patch 'OOZIE-2796-5.patch'.
Indeed SignalXCommand already loads WorkflowJobBean with protoActionConf. For
KillXCommand, I adjusted the named query for WorkflowJobQuery.GET_WORKFLOW_KILL
so that the protoActionConf is retrieved/set in returned bean. For the case of
ActionStartXCommand, its loadState() loads the bean using GET_WORKFLOW, but it
also has a constructor which takes an object of WorkflowJobBean, after tracing
the callers, eventually it all come to SignalXCommand.
For verification, those test cases I added in TestWfEndXCommand still apply. I
also added another test case when passed in WorkflowJobBean does not have
protoActionConf set, in which case the workflow action directory would be
deleted. I also verified end to end that following cases works:
1. succeeded workflow is able to preserve workflow directory.
2. killed workflow is able to preserve workflow directory.
3. suspended+resumed workflow is able to preserve workflow directory.
Please take a look.
> oozie.action.keep.action.dir not getting noticed
> ------------------------------------------------
>
> Key: OOZIE-2796
> URL: https://issues.apache.org/jira/browse/OOZIE-2796
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 4.3.0
> Reporter: Andras Piros
> Assignee: Xiaobin Zheng
> Fix For: trunk
>
> Attachments: OOZIE-2796-1.patch, OOZIE-2796-2.patch,
> OOZIE-2796-3.patch, OOZIE-2796-4.patch, OOZIE-2796-5.patch
>
>
> When trying to add following configuration entry:
> {code:xml}
> <property>
> <name>oozie.action.keep.action.dir</name>
> <value>true</value>
> </property>
> {code}
> to the application level configuration of {{workflow.xml}}, the workflow
> directories are removed just after the workflow has finished.
> This should not be the case.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
