[
https://issues.apache.org/jira/browse/OOZIE-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954838#comment-15954838
]
Hadoop QA commented on OOZIE-2850:
----------------------------------
Testing JIRA OOZIE-2850
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:red}-1{color} the patch contains 1 line(s) with tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:red}-1 RAT{color}
. {color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:red}-1{color} patch does not compile
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [509] new bugs found below threshold in total
that must be fixed.
. {color:red}-1{color} There are [98] new bugs found below threshold in
[server] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
server/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At CLIParser.java:[line 169]: Found reliance on default encoding in
org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new
java.io.PrintWriter(OutputStream)
. At CLIParser.java:[line 57]: new org.apache.oozie.cli.CLIParser(String,
String[]) may expose internal representation by storing an externally mutable
object into CLIParser.cliHelp
. At CLIParser.java:[lines 80-104]: Should
org.apache.oozie.cli.CLIParser$Command be a _static_ inner class?
. At OozieCLI.java:[line 845]: Found reliance on default encoding in
org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new
java.io.FileReader(File)
. At OozieCLI.java:[line 2175]: Found reliance on default encoding in
org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new
java.io.FileReader(File)
. {color:red}-1{color} There are [327] new bugs found below threshold in
[client] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
client/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At BinaryBlob.java:[line 68]: org.apache.oozie.BinaryBlob.getBytes() may
expose internal representation by returning BinaryBlob.bytes
. org.apache.oozie.BinaryBlob.getRawBlob() may expose internal representation
by returning BinaryBlob.rawBlob: Another occurrence at BinaryBlob.java:[line 88]
. Another occurrence at BinaryBlob.java:[line 116]: At BinaryBlob.java:[line 99]
. At BinaryBlob.java:[line 43]: new org.apache.oozie.BinaryBlob(byte[],
boolean) may expose internal representation by storing an externally mutable
object into BinaryBlob.bytes
. At BinaryBlob.java:[line 47]: new org.apache.oozie.BinaryBlob(byte[],
boolean) may expose internal representation by storing an externally mutable
object into BinaryBlob.rawBlob
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:red}-1{color} There are [42] new bugs found below threshold in
[hadooplibs/hadoop-utils-2] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
hadooplibs/hadoop-utils-2/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At OozieDBCLI.java:[line 548]: Found reliance on default encoding in
org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInMysql(String, Connection):
new java.io.FileWriter(String, boolean)
. At OozieDBCLI.java:[line 577]: Found reliance on default encoding in
org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInPostgres(String,
Connection, String): new java.io.FileWriter(String, boolean)
. At OozieDBCLI.java:[line 983]: Found reliance on default encoding in
org.apache.oozie.tools.OozieDBCLI.createOozieSysTable(String, boolean, String):
new java.io.FileWriter(String, boolean)
. At OozieDBCLI.java:[line 759]: Found reliance on default encoding in
org.apache.oozie.tools.OozieDBCLI.ddlTweaks(String, boolean): new
java.io.FileWriter(String, boolean)
. At OozieDBCLI.java:[line 712]: Found reliance on default encoding in
org.apache.oozie.tools.OozieDBCLI.ddlTweaksFor50(String, boolean, String): new
java.io.FileWriter(String, boolean)
. {color:red}-1{color} There are [6] new bugs found below threshold in [tools]
that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At DateList.java:[line 55]: Nullcheck of date at line 55 of value previously
dereferenced in org.apache.oozie.example.DateList.main(String[])
. Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is
never called: Redundant null check at DateList.java:[line 62]
. org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to
clean up java.io.InputStream: At DateList.java:[line 97]
. Path continues at LocalOozieExample.java:[line 76]: Obligation to clean up
resource created at LocalOozieExample.java:[line 72] is not discharged
. Path continues at LocalOozieExample.java:[line 78]: Path continues at
LocalOozieExample.java:[line 77]
. {color:red}-1{color} There are [1] new bugs found below threshold in
[examples] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
examples/findbugs-new.html
. The most important FindBugs errors are:
. At StreamingMain.java:[line 70]:
org.apache.oozie.action.hadoop.StreamingMain.addActionConf(JobConf,
Configuration) concatenates strings using + in a loop
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:red}-1{color} There are [19] new bugs found below threshold in
[sharelib/distcp] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
sharelib/distcp/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At LauncherMain.java:[line 73]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMain.getHadoopJobIds(String, Pattern[]):
new java.io.FileReader(String)
. At LauncherMain.java:[line 109]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMain.writeExternalChildIDs(String,
Pattern[], String): String.getBytes()
. At LauncherMain.java:[line 59]:
org.apache.oozie.action.hadoop.LauncherMain.HADOOP_SITE_FILES should be both
final and package protected
. At LauncherMain.java:[line 276]: Exceptional return value of
java.io.File.mkdirs() ignored in
org.apache.oozie.action.hadoop.LauncherMain.writeHadoopConfig(String, File)
. At LauncherMapper.java:[line 407]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File,
String, int): new java.io.FileReader(File)
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:red}-1{color} There are [3] new bugs found below threshold in
[sharelib/hcatalog] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
sharelib/hcatalog/findbugs-new.html
. The most important FindBugs errors are:
. At HiveMain.java:[line 349]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.HiveMain.readStringFromFile(String): new
java.io.FileReader(String)
. Obligation to clean up resource created at HiveMain.java:[line 178] is not
discharged:
org.apache.oozie.action.hadoop.HiveMain.setUpHiveLog4J(Configuration) may fail
to clean up java.io.OutputStream on checked exception
. org.apache.oozie.action.hadoop.HiveMain.setUpHiveSite() may fail to clean up
java.io.OutputStream on checked exception: Path continues at
HiveMain.java:[line 179]
. Path continues at HiveMain.java:[line 194]: Obligation to clean up resource
created at HiveMain.java:[line 193] is not discharged
. {color:red}-1{color} There are [3] new bugs found below threshold in
[sharelib/hive] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
sharelib/hive/findbugs-new.html
. The most important FindBugs errors are:
. At Hive2Main.java:[line 281]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.Hive2Main.readStringFromFile(String): new
java.io.FileReader(String)
. At Hive2Main.java:[line 270]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.Hive2Main.runBeeline(String[], String): new
java.io.PrintStream(OutputStream)
. At Hive2Main.java:[line 273]:
org.apache.oozie.action.hadoop.Hive2Main.runBeeline(String[], String) invokes
System.exit(...), which shuts down the entire virtual machine
. {color:red}-1{color} There are [8] new bugs found below threshold in
[sharelib/hive2] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
sharelib/hive2/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At OoziePigStats.java:[line 130]:
org.apache.oozie.action.hadoop.OoziePigStats.toJSONFromMultiStoreCounters(Map)
makes inefficient use of keySet iterator instead of entrySet iterator
. At PigMain.java:[line 344]: Dead store to klass in
org.apache.oozie.action.hadoop.PigMain.runPigJob(String[], String, boolean,
boolean)
. At PigMain.java:[line 316]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.PigMain.handleError(String): new
java.io.FileReader(String)
. At PigMain.java:[line 417]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.PigMain.writeExternalData(String, File): new
java.io.FileWriter(File)
. Obligation to clean up resource created at PigMain.java:[line 131] is not
discharged: org.apache.oozie.action.hadoop.PigMain.run(String[]) may fail to
clean up java.io.OutputStream on checked exception
. {color:red}-1{color} There are [2] new bugs found below threshold in
[sharelib/pig] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
sharelib/pig/findbugs-new.html
. The most important FindBugs errors are:
. At SparkMain.java:[line 506]:
org.apache.oozie.action.hadoop.SparkMain.getJarVersion(File) may fail to close
stream
. At SparkMain.java:[line 328]: Exceptional return value of
java.io.File.mkdirs() ignored in
org.apache.oozie.action.hadoop.SparkMain.createPySparkLibFolder()
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
. {color:red}-1{color} distro tarball fails with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3767/
> Fix default callback notifications
> ----------------------------------
>
> Key: OOZIE-2850
> URL: https://issues.apache.org/jira/browse/OOZIE-2850
> Project: Oozie
> Issue Type: Bug
> Reporter: Attila Sasvari
> Assignee: Attila Sasvari
> Priority: Trivial
> Attachments: OOZIE-2850-01.patch, OOZIE-2850-02.patch,
> OOZIE-2850-03.patch, OOZIE-2850-04.patch
>
>
> Currently oozie.service.CallbackService.base.url in oozie-default.xml is set
> to use
> [oozie.base.url/callback|
> https://github.com/apache/oozie/blob/7c404ad0ea4c61e90e8c86015de25ef196168c29/core/src/main/resources/oozie-default.xml#L1639]
> which defaults to
> [http://localhost:8080/oozie|https://github.com/apache/oozie/blob/7c404ad0ea4c61e90e8c86015de25ef196168c29/core/src/main/resources/oozie-default.xml#L105].
> As a result, actions finished are not detected by default. (Jetty listens on
> HTTP port 11000, see [port in oozie-default.xml |
> https://github.com/apache/oozie/blob/7c404ad0ea4c61e90e8c86015de25ef196168c29/core/src/main/resources/oozie-default.xml#L2535])
> {{oozie.http.hostname}} and {{oozie.http.port}} could be used in
> {{oozie.base.url}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
