----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58172/ -----------------------------------------------------------
(Updated April 7, 2017, 1:31 p.m.) Review request for oozie and Peter Bacsko. Changes ------- Updated based on code review comments. Repository: oozie-git Description ------- Sometimes when Oozie tries to acquire lock [via ZooKeeper](https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144) or [in-memory](https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java) we don't get enough information whether the action succeeded or not. Also other details like retry count, timeout applied, etc. are not logged. Enhancing logging here would benefit debugging of lock handling within `XCommand` instances. Diffs (updated) ----- core/src/main/java/org/apache/oozie/service/MemoryLocksService.java 2ab2abc34831daf75bf050b1e4c907afcb627978 core/src/main/java/org/apache/oozie/service/ZKLocksService.java 83790cf27772b106d39779d2ec5ccfa27ce52ef4 core/src/main/java/org/apache/oozie/util/XLog.java cc9abd83d2756e5dab1963ff4f97af7ec2517ab5 core/src/test/java/org/apache/oozie/service/TestZKLocksService.java d04f04e80a5a7ae9051d3a94feece82a9d460f67 Diff: https://reviews.apache.org/r/58172/diff/2/ Changes: https://reviews.apache.org/r/58172/diff/1-2/ Testing ------- New unit test created, existing ones that matter remained running. Thanks, András Piros
