----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58172/#review171859 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/ZKLocksService.java Lines 65 (patched) <https://reviews.apache.org/r/58172/#comment244866> I don't thing the log testing worth the effort of introducing this constructor. core/src/test/java/org/apache/oozie/service/TestZKLocksService.java Lines 560-584 (patched) <https://reviews.apache.org/r/58172/#comment244865> I don't thing this test is required. I don't like binding tests to log messages like this. - Peter Cseh On April 13, 2017, 12:13 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58172/ > ----------------------------------------------------------- > > (Updated April 13, 2017, 12:13 p.m.) > > > Review request for oozie, Peter Cseh and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > Sometimes when Oozie tries to acquire lock [via > ZooKeeper](https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144) > or > [in-memory](https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java) > we don't get enough information whether the action succeeded or not. Also > other details like retry count, timeout applied, etc. are not logged. > Enhancing logging here would benefit debugging of lock handling within > `XCommand` instances. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > 2ab2abc34831daf75bf050b1e4c907afcb627978 > core/src/main/java/org/apache/oozie/service/ZKLocksService.java > 83790cf27772b106d39779d2ec5ccfa27ce52ef4 > core/src/main/java/org/apache/oozie/util/XLog.java > cc9abd83d2756e5dab1963ff4f97af7ec2517ab5 > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > d04f04e80a5a7ae9051d3a94feece82a9d460f67 > > > Diff: https://reviews.apache.org/r/58172/diff/2/ > > > Testing > ------- > > New unit test created, existing ones that matter remained running. > > > Thanks, > > András Piros > >
