[
https://issues.apache.org/jira/browse/OOZIE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978639#comment-15978639
]
Peter Cseh commented on OOZIE-2829:
-----------------------------------
{quote}
using semicolon as separator might not be a good a idea in Linux. It can work
if you surround option args with double quotes, but probably it might better to
use colon as sharelibname separator.
{quote}
We should use a syntax that makes our life easier. I'm okay with using colons
as separators.
{quote}
I am also not sure that we want to allow adding individual files instead of
directories when specifying the sources.
{quote}
I like the idea to allow files in that list as it is providing more flexibility.
Regarding the patch:
# I would call {{copyAdditionalLibs}} all the time as iterating over an empty
set is not a problem
# Please check the format in {{getAdditionalLibs}} more strictly (e.g {{if
(addLibParts.lenght != 2) }} raise an exception, do not allow defining the same
sharelib twice.)
# I think it would make sense to use one thread pool for every copy operation.
# Please define the format of the additional libs part either in the help text
of the option or on a wiki page
# As we're not accepting and extracting tar files in the additional_libs, this
should be mentioned in the documentation
> Improve sharelib upload to accept multiple source folders
> ---------------------------------------------------------
>
> Key: OOZIE-2829
> URL: https://issues.apache.org/jira/browse/OOZIE-2829
> Project: Oozie
> Issue Type: Bug
> Components: tools
> Reporter: Peter Cseh
> Assignee: Attila Sasvari
> Attachments: OOZIE-2829-01.patch
>
>
> Right now sharelib can be created via {{sharelib create -fs FS_URI -locallib
> SHARED_LIBRARY}} where the SHARED_LIBRARY can be a tarbal or a folder.
> It would be nice to have the possibility to define additional folders to be
> uploaded into the sharelib, so the users don't have to copy or link the files
> together on their machine.
> The syntax could be something like -additional-lib
> sharelibName=/path/to/source/;/path/to/some/file,sharelibName2=/path/to/some/folder
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
