[
https://issues.apache.org/jira/browse/OOZIE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981110#comment-15981110
]
Attila Sasvari commented on OOZIE-2829:
---------------------------------------
[~gezapeti] thanks for the review comments.
1. fixed
2. fixed - also added more tests to test invalid inputs. I also extracted two
existing integration tests to a new test class. I wanted to use JUnit 4
annotations to check exception is thrown when the input is invalid.
3. OK
4. I adjusted help messages of CLI command to include more details (also
increased width in CLIParser):
{noformat}
usage:
OozieSharelibCLI creates or upgrade sharelib for oozie
oozie-setup.sh create <OPTIONS> : create a new timestamped version of
oozie sharelib
-additional_libs <arg> Additional sharelib
resources. This option requires a colon-separated list of pairs of
sharelibname and
coma-sperated list of pathnames in the following format:
"sharelib_name=pathname[,pathname...][,sharelib_name2=pathname[,pathname...]...]"
Caveats:
* Each pathname is either
a directory or a regular file (compressed files are not
extracted prior to the
upload operation).
* Sharelibnames shall be
specified only once.
* Do not upload multiple
conflicting library versions for an additional sharelib
directory as it may cause
runtime issues.
Example command:
$ oozie-setup.sh sharelib
create -fs hdfs://localhost:9000 -locallib \
oozie-sharelib.tar.gz
-additional_libs share2=dir2,file2:share3=file3
-concurrency <arg> Number of threads to be
used for copy operations. (default=1)
-fs <arg> URI of the fileSystem to
create oozie share library
-locallib <arg> Local share library
directory
{noformat}
5. I adjusted help messages of CLI command (see previous)
> Improve sharelib upload to accept multiple source folders
> ---------------------------------------------------------
>
> Key: OOZIE-2829
> URL: https://issues.apache.org/jira/browse/OOZIE-2829
> Project: Oozie
> Issue Type: Bug
> Components: tools
> Reporter: Peter Cseh
> Assignee: Attila Sasvari
> Attachments: OOZIE-2829-01.patch
>
>
> Right now sharelib can be created via {{sharelib create -fs FS_URI -locallib
> SHARED_LIBRARY}} where the SHARED_LIBRARY can be a tarbal or a folder.
> It would be nice to have the possibility to define additional folders to be
> uploaded into the sharelib, so the users don't have to copy or link the files
> together on their machine.
> The syntax could be something like -additional-lib
> sharelibName=/path/to/source/;/path/to/some/file,sharelibName2=/path/to/some/folder
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
