----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59134/#review174440 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/JPAService.java Line 66 (original), 69 (patched) <https://reviews.apache.org/r/59134/#comment247583> Whitespace core/src/main/java/org/apache/oozie/service/JPAService.java Lines 459 (patched) <https://reviews.apache.org/r/59134/#comment247584> This can only happen in case of a retry. Just a safety net - try to rollback if anything happened (which is probably unlikely). A failing rollback is not a problem, so it's ignored. core/src/main/java/org/apache/oozie/service/JPAService.java Lines 498 (patched) <https://reviews.apache.org/r/59134/#comment247582> Mistake: this should be two separate exception handlers. - Peter Bacsko On máj. 10, 2017, 9:23 de, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59134/ > ----------------------------------------------------------- > > (Updated máj. 10, 2017, 9:23 de) > > > Review request for oozie, András Piros and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2854 > > > Diffs > ----- > > core/pom.xml 14aa034 > core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 8d94c23 > core/src/main/java/org/apache/oozie/service/JPAService.java 028381d > core/src/main/java/org/apache/oozie/util/db/RetryHandlerFactory.java > PRE-CREATION > core/src/main/resources/oozie-default.xml e7a48a0 > > > Diff: https://reviews.apache.org/r/59134/diff/1/ > > > Testing > ------- > > Tested on a 3-node cluster. MySQL was killed/restared. The workflow execution > was not disrupted. > > > Thanks, > > Peter Bacsko > >
