> On máj. 10, 2017, 10:37 de, András Piros wrote: > > core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java > > Lines 49-51 (original), 61-71 (patched) > > <https://reviews.apache.org/r/59134/diff/1/?file=1713613#file1713613line62> > > > > When extracted to a nested class, could be unit tested separately.
As we discussed in person, we'll follow a different approach: subclass JPAService, override getEntityManager() then test with a mock EntityManager. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59134/#review174437 ----------------------------------------------------------- On máj. 10, 2017, 9:23 de, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59134/ > ----------------------------------------------------------- > > (Updated máj. 10, 2017, 9:23 de) > > > Review request for oozie, András Piros and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2854 > > > Diffs > ----- > > core/pom.xml 14aa034 > core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 8d94c23 > core/src/main/java/org/apache/oozie/service/JPAService.java 028381d > core/src/main/java/org/apache/oozie/util/db/RetryHandlerFactory.java > PRE-CREATION > core/src/main/resources/oozie-default.xml e7a48a0 > > > Diff: https://reviews.apache.org/r/59134/diff/1/ > > > Testing > ------- > > Tested on a 3-node cluster. MySQL was killed/restared. The workflow execution > was not disrupted. > > > Thanks, > > Peter Bacsko > >
