[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033905#comment-16033905
]
Robert Kanter commented on OOZIE-2867:
--------------------------------------
Some feedback:
# In {{DateUtils}}, we should use {{XLog.getLog(getClass());}} to get the logger
# The regex pattern is not correct; there's an extra space. It will currently
match something like {{A }} (capital letter followed by three spaces) instead
of {{ABC}}.
# On the previous point, we should have some unit tests to verify this
functionality
# "preffered" should be spelled "preferred"
# I think the warning should mention that "GMT, UTC, or Region/City are
preferred". I know "Region/City" isn't exactly correct, but in light of
something better, that's the best thing to call it. Most users who hit this
message are likely looking for a non-GMT/UTC timezone and the message doesn't
currently help them for that.
# Instead of having an empty if statement block, let's reverse the logic and
remove the else block
# Let's also try to positively recommend the "Region/City" format in the docs
instead of only negatively recommending not using the three letter formats.
# I think we can omit the sentence about some of the IDs being deprecated
> Timezone handling for Coordinators: emphasize "Continent/City" format
> ---------------------------------------------------------------------
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
> Affects Versions: 4.3.0
> Reporter: Andras Piros
> Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
