----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60963/#review181343 -----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java Lines 74 (patched) <https://reviews.apache.org/r/60963/#comment256890> Just a single whitespace or multiple? sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java Lines 75 (patched) <https://reviews.apache.org/r/60963/#comment256889> Could you explain this scenario? When is a key quoted and the value isn't? sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java Lines 77 (patched) <https://reviews.apache.org/r/60963/#comment256888> This is very confusing. What is the "value part" of a "parameter key"? sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java Lines 123 (patched) <https://reviews.apache.org/r/60963/#comment256886> isn't it "remains unquoted" ? sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java Lines 129 (patched) <https://reviews.apache.org/r/60963/#comment256887> Describe what it returns - Peter Bacsko On júl. 25, 2017, 10:03 de, András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60963/ > ----------------------------------------------------------- > > (Updated júl. 25, 2017, 10:03 de) > > > Review request for oozie, Attila Sasvari, Peter Cseh, Peter Bacsko, and > Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > Parse `spark-defaults.conf` values with spaces without needing the quotes. > That is, quotes should not be mandatory but optional to retain backwards > compatibility. > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > 30def6f05b7a17b8ce66ed766a9d64c171796ac5 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 7db26a6b81083d7664bef8ff14c8e14df4572fc1 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java > 02786a2476fc981af77688a22aa9c3a8fc0cce2a > > > Diff: https://reviews.apache.org/r/60963/diff/2/ > > > Testing > ------- > > Following tests are run: > > * `TestSparkOptionsSplitter` > * `TestSparkArgsExtractor` > * `TestSparkMain` > > > Thanks, > > András Piros > >
