> On July 25, 2017, 2:25 p.m., Peter Bacsko wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/60963/diff/2/?file=1782078#file1782078line74> > > > > Just a single whitespace or multiple?
Can be multiple, modified the description. > On July 25, 2017, 2:25 p.m., Peter Bacsko wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > > Lines 75 (patched) > > <https://reviews.apache.org/r/60963/diff/2/?file=1782078#file1782078line75> > > > > Could you explain this scenario? When is a key quoted and the value > > isn't? Modified the description. > On July 25, 2017, 2:25 p.m., Peter Bacsko wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > > Lines 77 (patched) > > <https://reviews.apache.org/r/60963/diff/2/?file=1782078#file1782078line77> > > > > This is very confusing. What is the "value part" of a "parameter key"? Modified the description. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60963/#review181343 ----------------------------------------------------------- On July 25, 2017, 10:03 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60963/ > ----------------------------------------------------------- > > (Updated July 25, 2017, 10:03 a.m.) > > > Review request for oozie, Attila Sasvari, Peter Cseh, Peter Bacsko, and > Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > Parse `spark-defaults.conf` values with spaces without needing the quotes. > That is, quotes should not be mandatory but optional to retain backwards > compatibility. > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > 30def6f05b7a17b8ce66ed766a9d64c171796ac5 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 7db26a6b81083d7664bef8ff14c8e14df4572fc1 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java > 02786a2476fc981af77688a22aa9c3a8fc0cce2a > > > Diff: https://reviews.apache.org/r/60963/diff/2/ > > > Testing > ------- > > Following tests are run: > > * `TestSparkOptionsSplitter` > * `TestSparkArgsExtractor` > * `TestSparkMain` > > > Thanks, > > András Piros > >
