----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61529/#review182565 -----------------------------------------------------------
client/src/main/resources/oozie-workflow-0.6.xsd Lines 143-147 (patched) <https://reviews.apache.org/r/61529/#comment258472> Can you extract these into separate xsd files? I think each action should get it's own sooner or later and this looks like a proper time for it. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 290-295 (patched) <https://reviews.apache.org/r/61529/#comment258473> This was moved to MRActionExecutor, don't put it back here. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 335-339 (patched) <https://reviews.apache.org/r/61529/#comment258474> MRActionExecutor. Remove this. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 872-877 (patched) <https://reviews.apache.org/r/61529/#comment258475> What't the intention behind this? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 999-1005 (patched) <https://reviews.apache.org/r/61529/#comment258476> Same as in lin 872 - Peter Cseh On Aug. 10, 2017, 9:40 a.m., Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61529/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 9:40 a.m.) > > > Review request for oozie and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > New workflow xsd to allow changing launcher configuration (e.g. setting java > system properties) > > > Diffs > ----- > > client/src/main/resources/hive-action-0.7.xsd PRE-CREATION > client/src/main/resources/hive2-action-0.3.xsd PRE-CREATION > client/src/main/resources/oozie-common-0.1.xsd PRE-CREATION > client/src/main/resources/oozie-workflow-0.6.xsd PRE-CREATION > client/src/main/resources/shell-action-0.4.xsd PRE-CREATION > client/src/main/resources/spark-action-0.3.xsd PRE-CREATION > client/src/main/resources/sqoop-action-0.5.xsd PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > dc17950418ada9b4848ed5597702a29e7124ab38 > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 8fdc50cce15271c13b20d1aaab2ffb95cb8fa711 > core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java > ffc29af2f834da6d0890ea7215c5a62fd7cd693e > core/src/main/java/org/apache/oozie/util/WritableUtils.java > aa027e37ba23d4f481698e0bcd93c26c763a0b1f > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a74e5c759fe3e336e7e98c61b8f5ac52efa4100c > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java > 23df0867e5984c518e8424d79365997bec28f619 > core/src/main/resources/oozie-default.xml > 0d174b5069aff36ca3a9d48722c5bba69623a046 > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > d74160a09ee237f4067e00ded526e7ec94528a6b > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 6cee7a8948ca7f2c7aaf44d4f172d18a1308a482 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > c51c64a18c74c73aa9907027992033a9975bf4d7 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 21332404bea79fe0a3cea045d57b3e52a1f15cae > core/src/test/resources/wf-schema-global-launcherconf-override.xml > PRE-CREATION > core/src/test/resources/wf-schema-global-launcherconf.xml PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d > > > Diff: https://reviews.apache.org/r/61529/diff/1/ > > > Testing > ------- > > - TestJavaActionExecutor, TestLiteWorkflowAppParser tests passed > - java-main example on pseudo hadoop succeeded, modified workflow xml so that > verbose class loading information is printed out of stdout of the launcher job > > > Thanks, > > Attila Sasvari > >
