-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61529/#review182566
-----------------------------------------------------------




client/src/main/resources/oozie-common-0.1.xsd
Lines 27 (patched)
<https://reviews.apache.org/r/61529/#comment258482>

    How do you imagine handling env? I could not see any examples for it.



core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Line 1115 (original), 1244 (patched)
<https://reviews.apache.org/r/61529/#comment258483>

    lancuer.env property is not parsed here.



core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Line 1376 (original), 1510 (patched)
<https://reviews.apache.org/r/61529/#comment258477>

    Have we decided to use a special <mr-jars> tag or createa a "map-reduce" 
sharelib that can be referenced?



core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java
Line 80 (original)
<https://reviews.apache.org/r/61529/#comment258478>

    Why remove this check?



core/src/main/resources/oozie-default.xml
Line 3077 (original), 3077-3106 (patched)
<https://reviews.apache.org/r/61529/#comment258479>

    Please file a follow-up jira to allow setting default core/memory/queue for 
launcher per action type



core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
Lines 308-310 (patched)
<https://reviews.apache.org/r/61529/#comment258480>

    Please add queue, priority, env and java-opts into this test as well



core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
Line 66 (original), 66 (patched)
<https://reviews.apache.org/r/61529/#comment258481>

    Don't use * imports



core/src/test/resources/wf-schema-global-launcherconf-override.xml
Lines 9-11 (patched)
<https://reviews.apache.org/r/61529/#comment258486>

    same



core/src/test/resources/wf-schema-global-launcherconf.xml
Lines 9 (patched)
<https://reviews.apache.org/r/61529/#comment258484>

    whitespaces!



core/src/test/resources/wf-schema-global-launcherconf.xml
Lines 11 (patched)
<https://reviews.apache.org/r/61529/#comment258485>

    Rat plugin will fail on this.



sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java
Lines 59 (patched)
<https://reviews.apache.org/r/61529/#comment258487>

    whitespace!


- Peter Cseh


On Aug. 10, 2017, 9:40 a.m., Attila Sasvari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61529/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 9:40 a.m.)
> 
> 
> Review request for oozie and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> New workflow xsd to allow changing launcher configuration (e.g. setting java 
> system properties)
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/hive-action-0.7.xsd PRE-CREATION 
>   client/src/main/resources/hive2-action-0.3.xsd PRE-CREATION 
>   client/src/main/resources/oozie-common-0.1.xsd PRE-CREATION 
>   client/src/main/resources/oozie-workflow-0.6.xsd PRE-CREATION 
>   client/src/main/resources/shell-action-0.4.xsd PRE-CREATION 
>   client/src/main/resources/spark-action-0.3.xsd PRE-CREATION 
>   client/src/main/resources/sqoop-action-0.5.xsd PRE-CREATION 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> dc17950418ada9b4848ed5597702a29e7124ab38 
>   core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 
> 8fdc50cce15271c13b20d1aaab2ffb95cb8fa711 
>   core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 
> ffc29af2f834da6d0890ea7215c5a62fd7cd693e 
>   core/src/main/java/org/apache/oozie/util/WritableUtils.java 
> aa027e37ba23d4f481698e0bcd93c26c763a0b1f 
>   
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
> a74e5c759fe3e336e7e98c61b8f5ac52efa4100c 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 
> 23df0867e5984c518e8424d79365997bec28f619 
>   core/src/main/resources/oozie-default.xml 
> 0d174b5069aff36ca3a9d48722c5bba69623a046 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 
> d74160a09ee237f4067e00ded526e7ec94528a6b 
>   core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java 
> 6cee7a8948ca7f2c7aaf44d4f172d18a1308a482 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> c51c64a18c74c73aa9907027992033a9975bf4d7 
>   
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
>  21332404bea79fe0a3cea045d57b3e52a1f15cae 
>   core/src/test/resources/wf-schema-global-launcherconf-override.xml 
> PRE-CREATION 
>   core/src/test/resources/wf-schema-global-launcherconf.xml PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 
> 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d 
> 
> 
> Diff: https://reviews.apache.org/r/61529/diff/1/
> 
> 
> Testing
> -------
> 
> - TestJavaActionExecutor, TestLiteWorkflowAppParser tests passed
> - java-main example on pseudo hadoop succeeded, modified workflow xml so that 
> verbose class loading information is printed out of stdout of the launcher job
> 
> 
> Thanks,
> 
> Attila Sasvari
> 
>

Reply via email to