----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62350/#review185501 -----------------------------------------------------------
tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java Lines 35 (patched) <https://reviews.apache.org/r/62350/#comment261799> Let's call this something more specific to what it's doing. Maybe "ECPolicyDisabler" or something like that. tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java Lines 44 (patched) <https://reviews.apache.org/r/62350/#comment261801> "Found Hadoop that supports Erasure Coding. Trying to disable Erasure Coding for " + path tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java Lines 58 (patched) <https://reviews.apache.org/r/62350/#comment261802> System.out.println("Done"); tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java Lines 61 (patched) <https://reviews.apache.org/r/62350/#comment261803> "Found Hadoop that does not support Erasure Coding. Not taking any action." tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java Lines 66 (patched) <https://reviews.apache.org/r/62350/#comment261800> Let's rename this to ``supportsErasureCoding()`` tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java Lines 68 (patched) <https://reviews.apache.org/r/62350/#comment261805> This is for the sharelib upload tool, so it will only happen once per JVM. So I don't think we need to bother caching it. - Robert Kanter On Sept. 15, 2017, 12:07 p.m., Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62350/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2017, 12:07 p.m.) > > > Review request for oozie, András Piros, Peter Cseh, and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-3054 > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java a844aa0f8 > > > Diff: https://reviews.apache.org/r/62350/diff/1/ > > > Testing > ------- > > > Thanks, > > Peter Bacsko > >
