> On szept. 15, 2017, 6:51 du, Robert Kanter wrote: > > tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java > > Lines 42 (patched) > > <https://reviews.apache.org/r/62350/diff/1/?file=1827863#file1827863line42> > > > > It would be good to have a unit test for this; but if that's not > > practical, I'm okay with you just verifying this on a cluster.
Unfortunately it isn't practical. To test the code path that disables EC, we need the Hadoop 3 classes on the classpath or generate these classes with matching method signatures dynamically with a tool like Javassist, but that would be too much trouble. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62350/#review185504 ----------------------------------------------------------- On szept. 15, 2017, 12:07 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62350/ > ----------------------------------------------------------- > > (Updated szept. 15, 2017, 12:07 du) > > > Review request for oozie, András Piros, Peter Cseh, and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-3054 > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java a844aa0f8 > > > Diff: https://reviews.apache.org/r/62350/diff/1/ > > > Testing > ------- > > > Thanks, > > Peter Bacsko > >
