> On Sept. 22, 2017, 9:20 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 334 (patched)
> > <https://reviews.apache.org/r/62470/diff/1/?file=1832290#file1832290line334>
> >
> > It's not very much readable ATM. Can you please call this very method
> > another way like `setupLauncherAndDefaultChildEnv()`, inside call the old
> > `setupLauncherConf()`, and have an empty implementation of
> > `addDefaultChildEnv()` that can be overridden e.g. in `SparkActionExecutor`.
>
> Satish Saley wrote:
> I have to create new setupLauncherConf() method to get actionConf. Not to
> disturb other action executor, I've overridden it here. actionConf has
> CONF_OOZIE_SPARK_SETUP_HADOOP_CONF_DIR which is needed while setting env
> variables.
I see. Indeed, what I was trying to explain here is:
```
JavaActionExecutor:
Configuration setupLauncherAndDefaultChildEnv(Configuration conf, Element
actionXml, Path appPath, Context context,
Configuration actionConf) throws ActionExecutorException {
setupLauncherConf(conf, actionXml, appPath, context);
addDefaultChildEnv();
}
protected void addDefaultChildEnv(Configuration conf, Configuration
actionConf) {
// Won't do anything here
}
SparkActionExecutor:
@Override
protected void addDefaultChildEnv(Configuration conf, Configuration
actionConf) {
// Implement here Spark-specific stuff
}
```
- András
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62470/#review185905
-----------------------------------------------------------
On Sept. 22, 2017, 10:40 p.m., Satish Saley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62470/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 10:40 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3062
> https://issues.apache.org/jira/browse/OOZIE-3062
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3062 Set HADOOP_CONF_DIR for spark action
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> be056038
> core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java
> 80d64ec8
>
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java
> d97f1f06
>
>
> Diff: https://reviews.apache.org/r/62470/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Satish Saley
>
>
