----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62470/#review186997 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Line 331 (original), 331 (patched) <https://reviews.apache.org/r/62470/#comment263948> Would like to disagree with András Piros comment on creating yet another method in JavaActionExecutor. It does not make it clean. We should not be renaming method to include every step done inside the method. Adding default child env is still part of setting up the launcher config and it does not require special mention in the method name and a new method. I would suggest reverting back to old method name and overriding it as in the initial patch. sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java Lines 136 (patched) <https://reviews.apache.org/r/62470/#comment263949> You can get rid of this and just use ArrayUtils.contains method from commons-lang - Rohini Palaniswamy On Oct. 3, 2017, 7:35 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62470/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2017, 7:35 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3062 > https://issues.apache.org/jira/browse/OOZIE-3062 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3062 Set HADOOP_CONF_DIR for spark action > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > be056038 > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 80d64ec8 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > d97f1f06 > > > Diff: https://reviews.apache.org/r/62470/diff/3/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
