[
https://issues.apache.org/jira/browse/OOZIE-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193569#comment-16193569
]
Attila Sasvari commented on OOZIE-3078:
---------------------------------------
[~andras.piros] thanks for the review. [~pbacsko] thanks for the fix. Do you
have other comments? [~gezapeti] can you also take a look?
Other comments:
- Right now the
[mask()|https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java#L119]
method throws an NPE if either key or value is {{null}}. It will cause a
workflow to fail... It might be better to just ignore those elements (i.e. do
not try to mask null-s). {{mask(String,String)}} is called from the public
method {{mask(Map<String, String> unmasked)}} (used by the Instrumentation
class).
> PasswordMasker throws NPE with null arguments
> ---------------------------------------------
>
> Key: OOZIE-3078
> URL: https://issues.apache.org/jira/browse/OOZIE-3078
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 5.0.0
> Reporter: Attila Sasvari
> Assignee: Attila Sasvari
> Attachments: OOZIE-3078-01.patch
>
>
> If
> [maskPasswordsIfNecessary|https://github.com/apache/oozie/blob/71d3ddc31cfb983dc83c51882f99c4429253230a/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java#L137]
> is called with a {{null}} argument, a NPE will be thrown. It should return
> false.
> Note: [SparkMain |
> https://github.com/apache/oozie/blob/71d3ddc31cfb983dc83c51882f99c4429253230a/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java#L88]
> uses this method.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
