[
https://issues.apache.org/jira/browse/OOZIE-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193757#comment-16193757
]
Peter Cseh commented on OOZIE-3078:
-----------------------------------
I think we should go ahead and make every public function's behavior the same.
After your patch every path going into [this
call|https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java#L120]
will throw an exception while this call will return "null" as the unmasked
value.
I think we should remove the precondition checking and say that we won't mask
the value even if the [key is null
here|https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java#L145]
so we won't break workflows with NPEs.
> PasswordMasker throws NPE with null arguments
> ---------------------------------------------
>
> Key: OOZIE-3078
> URL: https://issues.apache.org/jira/browse/OOZIE-3078
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 5.0.0
> Reporter: Attila Sasvari
> Assignee: Attila Sasvari
> Attachments: OOZIE-3078-01.patch
>
>
> If
> [maskPasswordsIfNecessary|https://github.com/apache/oozie/blob/71d3ddc31cfb983dc83c51882f99c4429253230a/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java#L137]
> is called with a {{null}} argument, a NPE will be thrown. It should return
> false.
> Note: [SparkMain |
> https://github.com/apache/oozie/blob/71d3ddc31cfb983dc83c51882f99c4429253230a/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java#L88]
> uses this method.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
