----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review187893 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Line 17 (original), 17 (patched) <https://reviews.apache.org/r/62936/#comment264948> Don't forget to add documentation. I'm not sure where is the best place though. I guess somewhere on the workflow page? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1154 (patched) <https://reviews.apache.org/r/62936/#comment264936> Shouldn't we check the workflow.xml first? Same with the others. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1197 (patched) <https://reviews.apache.org/r/62936/#comment264938> This is fine to leave for a different JIRA, but we should consider dropping the "oozie:launcher:" part of the name. The job type is now OOZIE, so it's probably redundent and we can shorten the names. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1211 (patched) <https://reviews.apache.org/r/62936/#comment264942> Should we log something here? A stack trace is unnecessary, but maybe something like "Invalid integer [X] specified for max attempts, using default [Y]". core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java Lines 1217-1221 (patched) <https://reviews.apache.org/r/62936/#comment264944> The log message might be misleading if you had a negative value. It would say that we're setting it, but then the if statement would make it not. Also, should we log something in the case of a negative value? core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationFilter.java Lines 29 (patched) <https://reviews.apache.org/r/62936/#comment264946> Should we make this all static? It doesn't really have any state and we're always calling it like: ```` new LauncherConfigurationFilter(actionDefaultConf).filter(launcherConf); ```` We could avoid creating the object by doing: ```` LauncherConfigurationFilter.filter(actionDefaultConf, launcherConf); ```` - Robert Kanter On Oct. 12, 2017, 3:33 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62936/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 3:33 p.m.) > > > Review request for oozie, Attila Sasvari, Peter Cseh, and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2896 Ensure compatibility for existing LauncherMapper settings > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 76d0daa4f7528de6fb3c8993bae4dd28b6f7865b > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationFilter.java > PRE-CREATION > core/src/main/resources/oozie-default.xml > 2389b993b7b1769521d6dd0c7386e99e7516210a > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > a7bd357f8938d148a150db43135a7a8fe7f0da4c > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationFilter.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > ee1a32ac9b071009e1dbe78396520d778f58bddc > > > Diff: https://reviews.apache.org/r/62936/diff/1/ > > > Testing > ------- > > JUnit tests: > > * `TestJavaActionExecutor` > * `TestLauncherConfigurationFilter` > > Functional tests: submit and run `examples/apps/java-main/workflow.xml` in > three modes: > > * only `oozie.launcher.` parameters are present: `oozie.launcher.` parameters > are passed through > * `oozie.launcher.` and override (`yarn.`, `mapreduce.`, and `mapred.`) > parameters are also present: `oozie.launcher.` parameters are passed through > * only override (`yarn.`, `mapreduce.`, and `mapred.`) parameters are > present: override parameters are passed through > > > Thanks, > > András Piros > >
