----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188290 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 32-61 (patched) <https://reviews.apache.org/r/62936/#comment265297> This is a good way to describe how the mechanism works in general. But it's still very difficult to figure how things are happening under the hood. Eg. how the property "mapreduce.map.cpu.vcores" eventually becomes "oozie.launcher.vcores". I think I understand it now, but it's rather complicated. Let's discuss this later. core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 41 (patched) <https://reviews.apache.org/r/62936/#comment265294> with instead of "w/" core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 47 (patched) <https://reviews.apache.org/r/62936/#comment265295> "with" instead of "w/" core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 57 (patched) <https://reviews.apache.org/r/62936/#comment265292> Could you rephrase this? It's weird to read "as defined" then "are defined". core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 95-96 (patched) <https://reviews.apache.org/r/62936/#comment265298> We really need simple examples as well. That's generally true for other local methods. Choose an arbitrary property and describe what the contents of the multimap become after this method runs. core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 129 (patched) <https://reviews.apache.org/r/62936/#comment265288> Possible typo: "overridden", "prepended" core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Lines 256 (patched) <https://reviews.apache.org/r/62936/#comment265290> So if we define oozie.launcher.something = 1, we'll have "oozie.launcher.something" and "something" as keys, with values = 1, correct? Is this what we want? - Peter Bacsko On okt. 16, 2017, 4:19 du, András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62936/ > ----------------------------------------------------------- > > (Updated okt. 16, 2017, 4:19 du) > > > Review request for oozie, Attila Sasvari, Peter Cseh, and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2896 Ensure compatibility for existing LauncherMapper settings > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 76d0daa4f7528de6fb3c8993bae4dd28b6f7865b > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/ConfigurationService.java > a51933022c14ea4ce06a65cc3c123bed8a8f7f34 > core/src/main/resources/oozie-default.xml > 2389b993b7b1769521d6dd0c7386e99e7516210a > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > a7bd357f8938d148a150db43135a7a8fe7f0da4c > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationInjector.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > ee1a32ac9b071009e1dbe78396520d778f58bddc > > > Diff: https://reviews.apache.org/r/62936/diff/2/ > > > Testing > ------- > > JUnit tests: > > * `TestJavaActionExecutor` > * `TestLauncherConfigurationFilter` > > Functional tests: submit and run `examples/apps/java-main/workflow.xml` in > three modes: > > * only `oozie.launcher.` parameters are present: `oozie.launcher.` parameters > are passed through > * `oozie.launcher.` and override (`yarn.`, `mapreduce.`, and `mapred.`) > parameters are also present: `oozie.launcher.` parameters are passed through > * only override (`yarn.`, `mapreduce.`, and `mapred.`) parameters are > present: override parameters are passed through > > > Thanks, > > András Piros > >
