[
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210731#comment-16210731
]
Andras Piros commented on OOZIE-3084:
-------------------------------------
[~asasvari] thanks for the review!
In fact I've checked that:
* no other Tomcat related options are needed to be put to Jetty startup scripts
* you're right, {{XLogService}} is started before (and should be started
before, since we need appropriate logging) before {{ConfigurationService}},
that's why {{oozie.instance.id}} is not considered inside the log messages
* with my patch {{oozie.instance.id}} is filled, please see my previous comment
As for the testing, I've looked at {{TestXLog}}, but couldn't find a way to
test any other thing that when a {{SERVER}} parameter is defined having the
{{ConversionPattern}} containing {{oozie.instance.id}}, and that system
property is set, log message would be rendered accordingly. This is the kind of
test what is already tested, and / or regards Log4J functionality. ATM I cannot
think of a test case where exactly the functionality covered by the patch
(setting the system property from the startup scripts cause the log message to
appear correctly) could be tested.
> Add missing JVM properties to Jetty startup script
> --------------------------------------------------
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
> Issue Type: Bug
> Components: scripts
> Affects Versions: 5.0.0
> Reporter: Andras Piros
> Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-3084.001.patch, OOZIE-3084.001.patch,
> OOZIE-3084.001.patch
>
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
> have been moved to
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
> Such an example is {{oozie.instance.id}}, causing we don't have any server
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed
> {{catalina_opts}} to {{jetty_opts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
