[
https://issues.apache.org/jira/browse/OOZIE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226987#comment-16226987
]
Attila Sasvari commented on OOZIE-3084:
---------------------------------------
[~andras.piros] thanks for the explanation.
Some comments:
- In XTestCase, do not use wildcard import.
{code}
import org.apache.oozie.util.*;
{code}
- Please run shellcheck against the modified shell scripts.
> Add missing JVM properties to Jetty startup script
> --------------------------------------------------
>
> Key: OOZIE-3084
> URL: https://issues.apache.org/jira/browse/OOZIE-3084
> Project: Oozie
> Issue Type: Bug
> Components: scripts
> Affects Versions: 5.0.0
> Reporter: Andras Piros
> Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-3084.001.patch, OOZIE-3084.001.patch,
> OOZIE-3084.001.patch, OOZIE-3084.002.patch
>
>
> In OOZIE-2666, when Oozie has moved from Tomcat to Jetty, we also moved the
> Tomcat related JVM options inside the startup script {{bin/oozied.sh}} to the
> more specific {{bin/oozie-jetty-server.sh}}.
> It seems that not all the
> [*{{catalina_opts}}*|https://github.com/apache/oozie/blob/branch-4.3/distro/src/main/bin/oozied.sh#L54-L74]
> have been moved to
> [*{{jetty_opts}}*|https://github.com/apache/oozie/blob/master/distro/src/main/bin/oozie-jetty-server.sh#L70-L86].
> Such an example is {{oozie.instance.id}}, causing we don't have any server
> name information within the Oozie server logs.
> So the task is to investigate startup scripts and put missing and needed
> {{catalina_opts}} to {{jetty_opts}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
