> On Oct. 19, 2017, 3:03 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 133 (patched) > > <https://reviews.apache.org/r/62936/diff/4/?file=1863476#file1863476line155> > > > > Any plans to add this to the XML schema? Or it's not that useful?
At the moment it's not that super useful, so decided not to add to the XML schema by now. > On Oct. 19, 2017, 3:03 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > > Lines 83-99 (patched) > > <https://reviews.apache.org/r/62936/diff/4/?file=1863477#file1863477line83> > > > > Now that's what I'm talkin' about! :D :D > On Oct. 19, 2017, 3:03 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > > Lines 224-241 (patched) > > <https://reviews.apache.org/r/62936/diff/4/?file=1863477#file1863477line224> > > > > Good comment again. > > > > Perhaps it would be worthwile to point out that > > "oozie.launcher.override.XX" will be "oozie.launcher.XX" just to be > > absolutely clear. Done. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188680 ----------------------------------------------------------- On Oct. 19, 2017, 10:04 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62936/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 10:04 a.m.) > > > Review request for oozie, Attila Sasvari, Peter Cseh, and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2896 Ensure compatibility for existing LauncherMapper settings > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 76d0daa4f7528de6fb3c8993bae4dd28b6f7865b > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/ConfigurationService.java > a51933022c14ea4ce06a65cc3c123bed8a8f7f34 > core/src/main/resources/oozie-default.xml > 9ba8fd4a0d9dd5f0bd6a64af3724c2f910d86457 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > a7bd357f8938d148a150db43135a7a8fe7f0da4c > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationInjector.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > ee1a32ac9b071009e1dbe78396520d778f58bddc > > > Diff: https://reviews.apache.org/r/62936/diff/4/ > > > Testing > ------- > > JUnit tests: > > * `TestJavaActionExecutor` > * `TestLauncherConfigurationFilter` > > Functional tests: submit and run `examples/apps/java-main/workflow.xml` in > three modes: > > * only `oozie.launcher.` parameters are present: `oozie.launcher.` parameters > are passed through > * `oozie.launcher.` and override (`yarn.`, `mapreduce.`, and `mapred.`) > parameters are also present: `oozie.launcher.` parameters are passed through > * only override (`yarn.`, `mapreduce.`, and `mapred.`) parameters are > present: override parameters are passed through > > > Thanks, > > András Piros > >
