----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64808/#review194448 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/control/ControlNodeActionExecutor.java Lines 55 (patched) <https://reviews.apache.org/r/64808/#comment273204> It should go to the end() method. core/src/main/java/org/apache/oozie/action/decision/DecisionActionExecutor.java Line 78 (original), 79 (patched) <https://reviews.apache.org/r/64808/#comment273205> It should go to the end() method. core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java Lines 117 (patched) <https://reviews.apache.org/r/64808/#comment273206> It should go to the end() method. core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java Lines 305 (patched) <https://reviews.apache.org/r/64808/#comment273207> It should go to the end() method. core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java Lines 431 (patched) <https://reviews.apache.org/r/64808/#comment273208> It depends on the actual filesystem the fs action run agains. So it is not necessary moved to a trash directory. In HDFS, trash can be disabled. core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java Lines 641 (patched) <https://reviews.apache.org/r/64808/#comment273209> It should go to the end() method. core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java Line 279 (original), 279 (patched) <https://reviews.apache.org/r/64808/#comment273210> It should go to the end() method. - Attila Sasvari On Dec. 22, 2017, 1:58 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64808/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2017, 1:58 p.m.) > > > Review request for oozie and Attila Sasvari. > > > Repository: oozie-git > > > Description > ------- > > Decision, ForkJoin, Email and FS ActionExecutors are producing no or very > little logs on info level. This makes it hard to gather usage information and > help with troubleshooting in the case of any issues. Please improve logging > in these classes. > Several subtasks can be separated out from this one > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/action/control/ControlNodeActionExecutor.java > cc1b6108 > > core/src/main/java/org/apache/oozie/action/decision/DecisionActionExecutor.java > 8c235bda > core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > d59f1d76 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 63f6104d > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > d62cf686 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 5890b8c1 > > > Diff: https://reviews.apache.org/r/64808/diff/1/ > > > Testing > ------- > > > Thanks, > > Kinga Marton > >
