----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64808/#review195300 -----------------------------------------------------------
Ship it! Ship It! - András Piros On Jan. 11, 2018, 4:02 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64808/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2018, 4:02 p.m.) > > > Review request for oozie and Attila Sasvari. > > > Repository: oozie-git > > > Description > ------- > > Decision, ForkJoin, Email and FS ActionExecutors are producing no or very > little logs on info level. This makes it hard to gather usage information and > help with troubleshooting in the case of any issues. Please improve logging > in these classes. > Several subtasks can be separated out from this one > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/action/control/ControlNodeActionExecutor.java > cc1b6108 > > core/src/main/java/org/apache/oozie/action/decision/DecisionActionExecutor.java > 8c235bda > core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > d59f1d76 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 63f6104d > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 5c8acae5 > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > d62cf686 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 5890b8c1 > > > Diff: https://reviews.apache.org/r/64808/diff/3/ > > > Testing > ------- > > Manually tested the log entries for each affected ActionExecutor. > The log messages look like: > > `2018-01-11 16:24:06,967 INFO ForkActionExecutor:520 - > SERVER[kmarton-MBP.local] USER[martonjuliakinga] GROUP[-] TOKEN[] > APP[Fork_workflow] JOB[0000001-180111155450212-oozie-mart-W] > ACTION[0000001-180111155450212-oozie-mart-W@fs-paralel] Starting action > ` > > `2018-01-11 14:40:22,770 INFO FsActionExecutor:520 - > SERVER[kmarton-MBP.local] USER[martonjuliakinga] GROUP[-] TOKEN[] > APP[one-op-wf] JOB[0000006-180111134310829-oozie-mart-W] > ACTION[0000006-180111134310829-oozie-mart-W@action1] Action ended with > external status [OK] > ` > > > Thanks, > > Kinga Marton > >
