----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64663/ -----------------------------------------------------------
(Updated Jan. 3, 2018, 7:39 p.m.) Review request for oozie. Changes ------- update to address review concerns * create ShellContentWriter class and test class * update temp file creation to use Junit TemporaryFolder * Make max size configurable * other review suggestions Repository: oozie-git Description ------- [OOZIE-2150] Shell launcher should print shell script Oozie shell launcher will dump script into log. The script is printed if it is (1) not too big and (2) appears to be plain-text (no null bytes). Diffs (updated) ----- core/src/main/resources/oozie-default.xml 1c348007 core/src/test/java/org/apache/oozie/action/hadoop/TestShellContentWriter.java PRE-CREATION sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellContentWriter.java PRE-CREATION sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 55d3d965 Diff: https://reviews.apache.org/r/64663/diff/2/ Changes: https://reviews.apache.org/r/64663/diff/1-2/ Testing ------- unit test added Thanks, Jacob Tolar
