----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64663/#review194742 -----------------------------------------------------------
While I think your changes point to a very good direction, here are my two more cents. core/src/test/java/org/apache/oozie/action/hadoop/TestShellContentWriter.java Lines 140 (patched) <https://reviews.apache.org/r/64663/#comment273713> For the negative-or-zero preconfigured value case I'd reformulate the error string as something like: ```Not printing script file as configured, content suppressed.``` sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellContentWriter.java Lines 64 (patched) <https://reviews.apache.org/r/64663/#comment273714> For the negative-or-zero preconfigured value case I'd reformulate the error string as something like: ```Not printing script file as configured, content suppressed.``` - András Piros On Jan. 3, 2018, 7:39 p.m., Jacob Tolar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64663/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 7:39 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > [OOZIE-2150] Shell launcher should print shell script > > Oozie shell launcher will dump script into log. The script is printed if it > is (1) not too big and (2) appears to be plain-text (no null bytes). > > > Diffs > ----- > > core/src/main/resources/oozie-default.xml 1c348007 > > core/src/test/java/org/apache/oozie/action/hadoop/TestShellContentWriter.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellContentWriter.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > 55d3d965 > > > Diff: https://reviews.apache.org/r/64663/diff/2/ > > > Testing > ------- > > unit test added > > > Thanks, > > Jacob Tolar > >
