[
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411781#comment-16411781
]
Hadoop QA commented on OOZIE-2645:
----------------------------------
Testing JIRA OOZIE-2645
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 2096
. Tests failed: 6
. Tests errors: 10
. The patch failed the following testcases:
testInstrumentation(org.apache.oozie.servlet.TestAdminServlet)
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testInstrumentation(org.apache.oozie.servlet.TestV1AdminServlet)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
testIsEnabled(org.apache.oozie.service.TestInstrumentationService)
testInstrumentation(org.apache.oozie.service.TestInstrumentationService)
. Tests failing with errors:
testActionCheckPreCondition1(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition2(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition3(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition4(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionStartPreCondition1(org.apache.oozie.command.wf.TestActionStartXCommand)
testActionStartPreCondition2(org.apache.oozie.command.wf.TestActionStartXCommand)
testActionStartPreCondition3(org.apache.oozie.command.wf.TestActionStartXCommand)
testEarlyCallbackTimeout(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testEarlyCallbackTransitionToRunning(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
. {color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/463/
> Deprecate Instrumentation in favor of Metrics
> ---------------------------------------------
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
> Issue Type: Improvement
> Components: monitoring
> Affects Versions: 5.0.0
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our
> homegrown Instrumentation. We left the Instrumentation as the default for
> compatibility; in Oozie 5, we should drop Instrumentation and only have
> Metrics.
> We can also use this opportunity to clean up the code and interface for
> Metrics, which currently has to conform to Instrumentation for pluggability.
> ----
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make
> {{MetricsInstrumentationService}} the default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
