[
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412669#comment-16412669
]
Hadoop QA commented on OOZIE-2645:
----------------------------------
Testing JIRA OOZIE-2645
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [1] new bugs found below threshold in [core]
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important FindBugs errors are:
. At MetricsInstrumentation.java:[line 434]:
org.apache.oozie.util.MetricsInstrumentation.getCounters() makes inefficient
use of keySet iterator instead of entrySet iterator
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 2096
. Tests failed: 1
. Tests errors: 2
. The patch failed the following testcases:
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
. Tests failing with errors:
testConnectionRetryExceptionListener(org.apache.oozie.service.TestJMSAccessorService)
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
. {color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/467/
> Deprecate Instrumentation in favor of Metrics
> ---------------------------------------------
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
> Issue Type: Improvement
> Components: monitoring
> Affects Versions: 5.0.0
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch, OOZIE-2645.002.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our
> homegrown Instrumentation. We left the Instrumentation as the default for
> compatibility; in Oozie 5, we should drop Instrumentation and only have
> Metrics.
> We can also use this opportunity to clean up the code and interface for
> Metrics, which currently has to conform to Instrumentation for pluggability.
> ----
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make
> {{MetricsInstrumentationService}} the default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
